fix: Remove flushAll method #850
Conversation
product-auto-label
bot
added
the
api: bigquerystorage
google-cla
bot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #850 +/- ##
============================================
- Coverage 80.74% 80.71% -0.03%
+ Complexity 990 987 -3
============================================
Files 74 74
Lines 5317 5306 -11
Branches 413 412 -1
============================================
- Hits 4293 4283 -10
+ Misses 849 848 -1
Partials 175 175
Continue to review full report at Codecov.
|
stephaniewang526
added
the
automerge
|
Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot. |
gcf-merge-on-green
bot
removed
the
automerge
| * | ||
| * @throws Exception | ||
| */ | ||
| public void flushAll(long timeoutMillis) throws Exception { |
There was a problem hiding this comment.
@yirutang Would you explain whether this removal is a backward compatible change from the library users's perspective?
(I'm surveying how much CLIRR helps Java libraries to follow semantic versioning or not)
There was a problem hiding this comment.
As of now I am pretty sure, there is no user on this. We would eventually provide this method but there is still some dispute about this.
Fixes a NullPointerException introduced in googleapis#841 which occured when trying to check the the requesterPays status of a file while authenticated with an invalid service account. Refs: googleapis#849, googleapis#841
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> ☕️