Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove IgnoreUnknownFields support on JsonStreamWriter #757

Merged
merged 12 commits into from Dec 30, 2020

Conversation

stephaniewang526
Copy link
Contributor

Original PR opened by @yirutang : #755

IgnoreUnknownFields is no longer supported on API level. So make JsonStreamWriter consistent with it.

@stephaniewang526 stephaniewang526 requested a review from a team December 30, 2020 20:31
@stephaniewang526 stephaniewang526 requested a review from a team as a code owner December 30, 2020 20:31
@product-auto-label product-auto-label bot added the api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. label Dec 30, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 30, 2020
@codecov
Copy link

codecov bot commented Dec 30, 2020

Codecov Report

Merging #757 (5e979df) into master (f3c897f) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #757      +/-   ##
============================================
- Coverage     80.80%   80.80%   -0.01%     
+ Complexity      985      983       -2     
============================================
  Files            73       73              
  Lines          5289     5283       -6     
  Branches        406      404       -2     
============================================
- Hits           4274     4269       -5     
+ Misses          845      844       -1     
  Partials        170      170              
Impacted Files Coverage Δ Complexity Δ
...oud/bigquery/storage/v1beta2/JsonStreamWriter.java 77.87% <100.00%> (+0.68%) 13.00 <1.00> (+1.00)
...d/bigquery/storage/v1beta2/JsonToProtoMessage.java 96.85% <100.00%> (-0.12%) 44.00 <0.00> (-3.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3c897f...5e979df. Read the comment docs.

@stephaniewang526 stephaniewang526 merged commit 0988105 into master Dec 30, 2020
@stephaniewang526 stephaniewang526 deleted the yirutang-removeignore branch December 30, 2020 20:52
shubhwip pushed a commit to shubhwip/java-bigquerystorage that referenced this pull request Oct 7, 2023
…onfig to v1.2.1 (googleapis#757)

[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [com.google.cloud:google-cloud-shared-config](https://togithub.com/googleapis/java-shared-config) | `1.2.0` -> `1.2.1` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/1.2.1/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/1.2.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/1.2.1/compatibility-slim/1.2.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/1.2.1/confidence-slim/1.2.0)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>googleapis/java-shared-config</summary>

### [`v1.2.1`](https://togithub.com/googleapis/java-shared-config/blob/master/CHANGELOG.md#&#8203;121-httpswwwgithubcomgoogleapisjava-shared-configcomparev120v121-2021-11-08)

[Compare Source](https://togithub.com/googleapis/java-shared-config/compare/v1.2.0...v1.2.1)

</details>

---

### Configuration

📅 **Schedule**: At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-storage-nio).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants