Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding JsonToProtoMessage.java #400

Merged
merged 21 commits into from Jul 21, 2020

Conversation

allenc3
Copy link
Contributor

@allenc3 allenc3 commented Jul 7, 2020

Added JsonToProtoMessage.java which can convert json data to protocol buffer data given the protocol buffer descriptor.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 7, 2020
@codecov
Copy link

codecov bot commented Jul 7, 2020

Codecov Report

Merging #400 into master will increase coverage by 0.79%.
The diff coverage is 96.96%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #400      +/-   ##
============================================
+ Coverage     77.02%   77.82%   +0.79%     
- Complexity      576      623      +47     
============================================
  Files            55       56       +1     
  Lines          3391     3535     +144     
  Branches        193      234      +41     
============================================
+ Hits           2612     2751     +139     
- Misses          668      677       +9     
+ Partials        111      107       -4     
Impacted Files Coverage Δ Complexity Δ
.../bigquery/storage/v1alpha2/JsonToProtoMessage.java 96.96% <96.96%> (ø) 47.00 <47.00> (?)
...ery/storage/v1beta1/BaseBigQueryStorageClient.java 60.34% <0.00%> (-10.25%) 19.00% <0.00%> (ø%)
.../cloud/bigquery/storage/v1alpha2/StreamWriter.java 80.60% <0.00%> (+0.23%) 33.00% <0.00%> (ø%)
...rage/v1beta1/stub/BigQueryStorageStubSettings.java 85.23% <0.00%> (+0.51%) 14.00% <0.00%> (ø%)
...ud/bigquery/storage/v1/BaseBigQueryReadClient.java 43.90% <0.00%> (+2.43%) 10.00% <0.00%> (ø%)
...gquery/storage/v1beta2/BaseBigQueryReadClient.java 43.90% <0.00%> (+2.43%) 10.00% <0.00%> (ø%)
...bigquery/storage/v1alpha2/BigQueryWriteClient.java 58.57% <0.00%> (+5.71%) 28.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90bb713...1065d26. Read the comment docs.

@allenc3 allenc3 force-pushed the JsonToProtoMessage branch 2 times, most recently from cba9d39 to 3ea5b56 Compare July 13, 2020 16:43
Copy link

@Wilson720 Wilson720 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

…values first. This prevents catching unexpected JsonExceptions and blocking the actual error message.
@allenc3 allenc3 marked this pull request as ready for review July 21, 2020 17:12
@stephaniewang526 stephaniewang526 added kokoro:force-run Add this label to force Kokoro to re-run the tests. automerge Merge the pull request once unit tests and other checks pass. labels Jul 21, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 21, 2020
@stephaniewang526 stephaniewang526 merged commit 200da6d into googleapis:master Jul 21, 2020
shubhwip pushed a commit to shubhwip/java-bigquerystorage that referenced this pull request Oct 7, 2023
* test: attempt tests up to 3 times

* chore: run formatter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants