fix: waitForTermination in the manual client #140 #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
yirutang
changed the title
|
Please correct initial commit msg to "fix: waitForTermination" so that conventionalcommit check will pass. FYI, this is also what's used in triggering our release pipeline. |
stephaniewang526
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
stephaniewang526
changed the title
stephaniewang526
approved these changes
Apr 6, 2020
stephaniewang526
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #140 ☕️
After the fix, close() should fully work. So I updated the unit test to use close().
Also fixed a issue in reconnection.