Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stream is not properly closed in writeapi manual client #140

Closed
yirutang opened this issue Apr 4, 2020 · 0 comments · Fixed by #141
Closed

Stream is not properly closed in writeapi manual client #140

yirutang opened this issue Apr 4, 2020 · 0 comments · Fixed by #141
Assignees
@yirutang
Labels
🚨 This issue needs some love. triage me I really want to be triaged.

Comments

@yirutang
Copy link
Contributor

yirutang commented Apr 4, 2020

We need to close the stream in shutdown.
@yirutang yirutang mentioned this issue Apr 4, 2020
Merged
@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Apr 5, 2020
stephaniewang526 pushed a commit that referenced this issue Apr 7, 2020
@yirutang
fix: waitForTermination in the manual client #140 (#141)
bdb8e0f 
* fix: waitForTermination

* .

* .

* fix: waitForTermination

* reword

* .
@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Apr 9, 2020
shubhwip pushed a commit to shubhwip/java-bigquerystorage that referenced this issue Oct 7, 2023
@renovate-bot
chore(deps): update dependency com.google.cloud:google-cloud-nio to v…
214aa4f 
…0.121.1 (googleapis#140)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yirutang yirutang

Labels
🚨 This issue needs some love. triage me I really want to be triaged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: waitForTermination in the manual client #140
2 participants
@yirutang @yoshi-automation