Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for StorageError #1391

Merged
merged 19 commits into from Nov 15, 2021
Merged

feat: add support for StorageError #1391

merged 19 commits into from Nov 15, 2021

Conversation

stephaniewang526
Copy link
Contributor

Fixes b/203003176

@stephaniewang526 stephaniewang526 requested review from a team and shollyman October 29, 2021 15:52
@product-auto-label product-auto-label bot added the api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. label Oct 29, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 29, 2021
@stephaniewang526 stephaniewang526 requested a review from a team as a code owner October 29, 2021 15:54
Copy link
Contributor

@yirutang yirutang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but there is a missing part, is there a way to add the same process when the API call failed, aka, in terms of connection error?

It is when the Done function is called on AppendRows.

Copy link
Contributor

@BenWhitehead BenWhitehead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two bugs, and the reason your tests builds are all hung and will likely need to timeout.

An exception is being thrown because the map is null while trying to initialize the exception most likely going into a loop or something.

Co-authored-by: BenWhitehead <BenWhitehead@users.noreply.github.com>
Copy link
Contributor

@yirutang yirutang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@stephaniewang526 stephaniewang526 added the automerge Merge the pull request once unit tests and other checks pass. label Nov 12, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Nov 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants