From f536fc7c998ac7d6c54e7d8b3bb7f9a2d6b5626b Mon Sep 17 00:00:00 2001 From: Yiru Tang Date: Mon, 19 Oct 2020 08:59:54 -0700 Subject: [PATCH] fix: Due to backend issues resolved, we no longer need to wait for 5 seconds between reconnection (#610) --- .../cloud/bigquery/storage/v1alpha2/StreamWriter.java | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/StreamWriter.java b/google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/StreamWriter.java index b30b16ea25..e146169cb1 100644 --- a/google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/StreamWriter.java +++ b/google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/StreamWriter.java @@ -126,8 +126,6 @@ public class StreamWriter implements AutoCloseable { // Used for schema updates private OnSchemaUpdateRunnable onSchemaUpdateRunnable; - private final int REFRESH_STREAM_WAIT_TIME = 7; - /** The maximum size of one request. Defined by the API. */ public static long getApiMaxRequestBytes() { return 10L * 1000L * 1000L; // 10 megabytes (https://en.wikipedia.org/wiki/Megabyte) @@ -356,12 +354,7 @@ public void refreshAppend() throws IOException, InterruptedException { } } catch (InterruptedException expected) { } - // Currently there is a bug that it took reconnected stream 5 seconds to pick up - // stream count. So wait at least 7 seconds before sending a new request. - Thread.sleep( - Math.max( - this.retrySettings.getInitialRetryDelay().toMillis(), - Duration.ofSeconds(REFRESH_STREAM_WAIT_TIME).toMillis())); + Thread.sleep(this.retrySettings.getInitialRetryDelay().toMillis()); // Can only unlock here since need to sleep the full 7 seconds before stream can allow appends. appendAndRefreshAppendLock.unlock(); LOG.info("Write Stream " + streamName + " connection established");