From a1b1c8edce87a8d33faf1067f617e3f47c4afc45 Mon Sep 17 00:00:00 2001 From: Yiru Tang Date: Mon, 14 Dec 2020 11:00:08 -0800 Subject: [PATCH] fix: a build break caused by breaking change. (#729) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [ ] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/java-bigquerystorage/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [ ] Ensure the tests and linter pass - [ ] Code coverage does not decrease (if any source code was changed) - [ ] Appropriate docs were updated (if necessary) Fixes # ☕️ --- .../google/cloud/bigquery/storage/v1beta2/StreamWriter.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1beta2/StreamWriter.java b/google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1beta2/StreamWriter.java index 3cee9a457f..f55364325a 100644 --- a/google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1beta2/StreamWriter.java +++ b/google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1beta2/StreamWriter.java @@ -486,14 +486,14 @@ private void onSuccess(AppendRowsResponse response) { for (int i = 0; i < inflightRequests.size(); i++) { AppendRowsResponse.Builder singleResponse = response.toBuilder(); if (offsetList.get(i) > 0) { - singleResponse.setOffset(offsetList.get(i)); + // singleResponse.setOffset(offsetList.get(i)); } else { long actualOffset = response.getOffset(); for (int j = 0; j < i; j++) { actualOffset += inflightRequests.get(j).message.getProtoRows().getRows().getSerializedRowsCount(); } - singleResponse.setOffset(actualOffset); + // singleResponse.setOffset(actualOffset); } inflightRequests.get(i).appendResult.set(singleResponse.build()); }