From 3b5cdbe769fcebeebc571922c84c129066e76aaf Mon Sep 17 00:00:00 2001 From: emkornfield Date: Fri, 11 Jun 2021 11:40:07 -0700 Subject: [PATCH] fix: Make EOS Matching more robust (#1128) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit fix: Make EOS Matching more robust Clients are seeing a different variant now: Received unexpected EOS on empty DATA frame from server Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [x] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/java-bigquerystorage/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [x] Ensure the tests and linter pass - [x] Code coverage does not decrease (if any source code was changed) - [x] Appropriate docs were updated (if necessary) Fixes # ☕️ --- .../java/com/google/cloud/bigquery/storage/util/Errors.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/util/Errors.java b/google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/util/Errors.java index d57bb3f11f..067f8d242d 100644 --- a/google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/util/Errors.java +++ b/google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/util/Errors.java @@ -31,7 +31,7 @@ public static boolean isRetryableInternalStatus(Status status) { String description = status.getDescription(); return status.getCode() == Status.Code.INTERNAL && description != null - && (description.contains("Received unexpected EOS on DATA frame from server") + && (description.contains("Received unexpected EOS ") || description.contains(" Rst ") || description.contains("RST_STREAM") || description.contains("Connection closed with unknown cause")