From 1c85e8fbf5b2b4e2073c72a86efd83812cabac37 Mon Sep 17 00:00:00 2001 From: Elliotte Rusty Harold Date: Fri, 2 Oct 2020 11:36:42 -0400 Subject: [PATCH] fix: remove apache commons lang (#585) --- google-cloud-bigquerystorage/pom.xml | 4 ---- .../cloud/bigquery/storage/v1alpha2/StreamWriterTest.java | 6 +++--- pom.xml | 6 ------ renovate.json | 1 - 4 files changed, 3 insertions(+), 14 deletions(-) diff --git a/google-cloud-bigquerystorage/pom.xml b/google-cloud-bigquerystorage/pom.xml index 6473db6328..f808c30e66 100644 --- a/google-cloud-bigquerystorage/pom.xml +++ b/google-cloud-bigquerystorage/pom.xml @@ -104,10 +104,6 @@ org.threeten threetenbp - - org.apache.commons - commons-lang3 - org.json json diff --git a/google-cloud-bigquerystorage/src/test/java/com/google/cloud/bigquery/storage/v1alpha2/StreamWriterTest.java b/google-cloud-bigquerystorage/src/test/java/com/google/cloud/bigquery/storage/v1alpha2/StreamWriterTest.java index 2f9160f156..778164f6b0 100644 --- a/google-cloud-bigquerystorage/src/test/java/com/google/cloud/bigquery/storage/v1alpha2/StreamWriterTest.java +++ b/google-cloud-bigquerystorage/src/test/java/com/google/cloud/bigquery/storage/v1alpha2/StreamWriterTest.java @@ -37,6 +37,7 @@ import com.google.api.gax.rpc.DataLossException; import com.google.cloud.bigquery.storage.test.Test.FooType; import com.google.cloud.bigquery.storage.v1alpha2.Storage.*; +import com.google.common.base.Strings; import com.google.protobuf.DescriptorProtos; import com.google.protobuf.Int64Value; import com.google.protobuf.Timestamp; @@ -47,7 +48,6 @@ import java.util.concurrent.ExecutionException; import java.util.concurrent.TimeUnit; import java.util.logging.Logger; -import org.apache.commons.lang3.StringUtils; import org.junit.After; import org.junit.Assert; import org.junit.Before; @@ -262,9 +262,9 @@ public void testAppendByNumBytes() throws Exception { assertEquals(1L, appendFuture2.get().getOffset()); assertFalse(appendFuture3.isDone()); - // This message is big enough to trigger send on the pervious message and itself. + // This message is big enough to trigger send on the previous message and itself. ApiFuture appendFuture4 = - sendTestMessage(writer, new String[] {StringUtils.repeat('A', 100)}); + sendTestMessage(writer, new String[] {Strings.repeat("A", 100)}); assertEquals(2L, appendFuture3.get().getOffset()); assertEquals(3L, appendFuture4.get().getOffset()); diff --git a/pom.xml b/pom.xml index 3b7438c67f..2928f367ed 100644 --- a/pom.xml +++ b/pom.xml @@ -65,7 +65,6 @@ github google-cloud-bigquerystorage-parent 2.11.3 - 3.5 @@ -150,11 +149,6 @@ jackson-core ${jackson-core.version} - - org.apache.commons - commons-lang3 - ${commons-lang3.version} - org.json json diff --git a/renovate.json b/renovate.json index 3db479b607..458c922f7f 100644 --- a/renovate.json +++ b/renovate.json @@ -76,7 +76,6 @@ "groupName": "jackson dependencies" } ], - "ignoreDeps": ["org.apache.commons:commons-lang3"], "semanticCommits": true, "masterIssue": true } \ No newline at end of file