fix: remove apache commons lang (#585)

googleapis · Oct 2, 2020 · 1c85e8f · 1c85e8f
1 parent 8d800fa
commit 1c85e8f
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 14 deletions.
diff --git a/google-cloud-bigquerystorage/pom.xml b/google-cloud-bigquerystorage/pom.xml
@@ -104,10 +104,6 @@
       <groupId>org.threeten</groupId>
       <artifactId>threetenbp</artifactId>
     </dependency>
-    <dependency>
-      <groupId>org.apache.commons</groupId>
-      <artifactId>commons-lang3</artifactId>
-    </dependency>
     <dependency>
       <groupId>org.json</groupId>
       <artifactId>json</artifactId>

diff --git a/...erystorage/src/test/java/com/google/cloud/bigquery/storage/v1alpha2/StreamWriterTest.java b/...erystorage/src/test/java/com/google/cloud/bigquery/storage/v1alpha2/StreamWriterTest.java
@@ -37,6 +37,7 @@
 import com.google.api.gax.rpc.DataLossException;
 import com.google.cloud.bigquery.storage.test.Test.FooType;
 import com.google.cloud.bigquery.storage.v1alpha2.Storage.*;
+import com.google.common.base.Strings;
 import com.google.protobuf.DescriptorProtos;
 import com.google.protobuf.Int64Value;
 import com.google.protobuf.Timestamp;
@@ -47,7 +48,6 @@
 import java.util.concurrent.ExecutionException;
 import java.util.concurrent.TimeUnit;
 import java.util.logging.Logger;
-import org.apache.commons.lang3.StringUtils;
 import org.junit.After;
 import org.junit.Assert;
 import org.junit.Before;
@@ -262,9 +262,9 @@ public void testAppendByNumBytes() throws Exception {
     assertEquals(1L, appendFuture2.get().getOffset());
     assertFalse(appendFuture3.isDone());
 
-    // This message is big enough to trigger send on the pervious message and itself.
+    // This message is big enough to trigger send on the previous message and itself.
     ApiFuture<AppendRowsResponse> appendFuture4 =
-        sendTestMessage(writer, new String[] {StringUtils.repeat('A', 100)});
+        sendTestMessage(writer, new String[] {Strings.repeat("A", 100)});
     assertEquals(2L, appendFuture3.get().getOffset());
     assertEquals(3L, appendFuture4.get().getOffset());
 

diff --git a/pom.xml b/pom.xml
@@ -65,7 +65,6 @@
     <github.global.server>github</github.global.server>
     <site.installationModule>google-cloud-bigquerystorage-parent</site.installationModule>
     <jackson-core.version>2.11.3</jackson-core.version>
-    <commons-lang3.version>3.5</commons-lang3.version>
   </properties>
 
   <pluginRepositories>
@@ -150,11 +149,6 @@
         <artifactId>jackson-core</artifactId>
         <version>${jackson-core.version}</version>
       </dependency>
-      <dependency>
-        <groupId>org.apache.commons</groupId>
-        <artifactId>commons-lang3</artifactId>
-        <version>${commons-lang3.version}</version>
-      </dependency>
       <dependency>
         <groupId>org.json</groupId>
         <artifactId>json</artifactId>

diff --git a/renovate.json b/renovate.json
@@ -76,7 +76,6 @@
       "groupName": "jackson dependencies"
     }
   ],
-  "ignoreDeps": ["org.apache.commons:commons-lang3"],
   "semanticCommits": true,
   "masterIssue": true
 }