fix: BQ Numeric is compatible with double and float protobuf types (#367

) Fixed a bug and made BQ Numeric compatible with double and float protobuf types.
googleapis · Jun 22, 2020 · 1b2f110 · 1b2f110
1 parent 67626bd
commit 1b2f110
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/...storage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/SchemaCompatibility.java b/...storage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/SchemaCompatibility.java
@@ -206,6 +206,11 @@ private static boolean isCompatibleWithBQNumeric(Descriptors.FieldDescriptor.Typ
       return true;
     }
 
+    if (field == Descriptors.FieldDescriptor.Type.FLOAT
+        || field == Descriptors.FieldDescriptor.Type.DOUBLE) {
+      return true;
+    }
+
     return false;
   }
 

diff --git a/...age/src/test/java/com/google/cloud/bigquery/storage/v1alpha2/SchemaCompatibilityTest.java b/...age/src/test/java/com/google/cloud/bigquery/storage/v1alpha2/SchemaCompatibilityTest.java
@@ -729,7 +729,9 @@ public void testBQNumeric() {
                 Fixed64Type.getDescriptor(),
                 SFixed32Type.getDescriptor(),
                 SFixed64Type.getDescriptor(),
-                BytesType.getDescriptor()));
+                BytesType.getDescriptor(),
+                FloatType.getDescriptor(),
+                DoubleType.getDescriptor()));
 
     for (Descriptors.Descriptor descriptor : type_descriptors) {
       if (compatible.contains(descriptor)) {