fix: remove excessive StreamWriter info logging (#1359)

Fixing an internal feedback bug: b/202883481
googleapis · Oct 18, 2021 · 0d27d5a · 0d27d5a
1 parent 03f9d75
commit 0d27d5a
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 14 deletions.
diff --git a/...loud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1/StreamWriter.java b/...loud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1/StreamWriter.java
@@ -307,7 +307,7 @@ public void close() {
     } finally {
       this.lock.unlock();
     }
-    log.info("Waiting for append thread to finish. Stream: " + streamName);
+    log.fine("Waiting for append thread to finish. Stream: " + streamName);
     try {
       appendThread.join();
       log.info("User close complete. Stream: " + streamName);
@@ -366,17 +366,17 @@ private void appendLoop() {
       }
     }
 
-    log.info("Cleanup starts. Stream: " + streamName);
+    log.fine("Cleanup starts. Stream: " + streamName);
     // At this point, the waiting queue is drained, so no more requests.
     // We can close the stream connection and handle the remaining inflight requests.
     this.streamConnection.close();
     waitForDoneCallback();
 
     // At this point, there cannot be more callback. It is safe to clean up all inflight requests.
-    log.info(
+    log.fine(
         "Stream connection is fully closed. Cleaning up inflight requests. Stream: " + streamName);
     cleanupInflightRequests();
-    log.info("Append thread is done. Stream: " + streamName);
+    log.fine("Append thread is done. Stream: " + streamName);
   }
 
   /*
@@ -396,7 +396,7 @@ private boolean waitingQueueDrained() {
   }
 
   private void waitForDoneCallback() {
-    log.info("Waiting for done callback from stream connection. Stream: " + streamName);
+    log.fine("Waiting for done callback from stream connection. Stream: " + streamName);
     while (true) {
       this.lock.lock();
       try {
@@ -441,7 +441,7 @@ private void cleanupInflightRequests() {
     } finally {
       this.lock.unlock();
     }
-    log.info(
+    log.fine(
         "Cleaning "
             + localQueue.size()
             + " inflight requests with error: "
@@ -471,7 +471,7 @@ private void requestCallback(AppendRowsResponse response) {
   }
 
   private void doneCallback(Throwable finalStatus) {
-    log.info(
+    log.fine(
         "Received done callback. Stream: "
             + streamName
             + " Final status: "

diff --git a/...gquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1beta2/StreamWriterV2.java b/...gquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1beta2/StreamWriterV2.java
@@ -307,7 +307,7 @@ public void close() {
     } finally {
       this.lock.unlock();
     }
-    log.info("Waiting for append thread to finish. Stream: " + streamName);
+    log.fine("Waiting for append thread to finish. Stream: " + streamName);
     try {
       appendThread.join();
       log.info("User close complete. Stream: " + streamName);
@@ -366,17 +366,17 @@ private void appendLoop() {
       }
     }
 
-    log.info("Cleanup starts. Stream: " + streamName);
+    log.fine("Cleanup starts. Stream: " + streamName);
     // At this point, the waiting queue is drained, so no more requests.
     // We can close the stream connection and handle the remaining inflight requests.
     this.streamConnection.close();
     waitForDoneCallback();
 
     // At this point, there cannot be more callback. It is safe to clean up all inflight requests.
-    log.info(
+    log.fine(
         "Stream connection is fully closed. Cleaning up inflight requests. Stream: " + streamName);
     cleanupInflightRequests();
-    log.info("Append thread is done. Stream: " + streamName);
+    log.fine("Append thread is done. Stream: " + streamName);
   }
 
   /*
@@ -396,7 +396,7 @@ private boolean waitingQueueDrained() {
   }
 
   private void waitForDoneCallback() {
-    log.info("Waiting for done callback from stream connection. Stream: " + streamName);
+    log.fine("Waiting for done callback from stream connection. Stream: " + streamName);
     while (true) {
       this.lock.lock();
       try {
@@ -441,7 +441,7 @@ private void cleanupInflightRequests() {
     } finally {
       this.lock.unlock();
     }
-    log.info(
+    log.fine(
         "Cleaning "
             + localQueue.size()
             + " inflight requests with error: "
@@ -471,7 +471,7 @@ private void requestCallback(AppendRowsResponse response) {
   }
 
   private void doneCallback(Throwable finalStatus) {
-    log.info(
+    log.fine(
         "Received done callback. Stream: "
             + streamName
             + " Final status: "