Skip to content
This repository has been archived by the owner on Sep 27, 2023. It is now read-only.

feat: migrate bigquerydatatransfer from google-cloud-java, add bom #3

Merged
merged 5 commits into from Dec 5, 2019
Merged

feat: migrate bigquerydatatransfer from google-cloud-java, add bom #3

merged 5 commits into from Dec 5, 2019

Conversation

stephaniewang526
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 5, 2019
@stephaniewang526 stephaniewang526 changed the title add pom.xml chore: migrate bigquerydatatransfer from google-cloud-java Dec 5, 2019
@chingor13 chingor13 changed the title chore: migrate bigquerydatatransfer from google-cloud-java feat: migrate bigquerydatatransfer from google-cloud-java, add bom Dec 5, 2019
chingor13
chingor13 reviewed Dec 5, 2019
View reviewed changes
Copy link
Contributor

@chingor13 chingor13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, we separate the regen changes from the template file changes

target/checkstyle-result.xml Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Dec 5, 2019 •
edited

Codecov Report

❗ No coverage uploaded for pull request base (master@f3cee8d). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##             master    #3   +/-   ##
======================================
  Coverage          ?   75%           
  Complexity        ?   105           
======================================
  Files             ?     7           
  Lines             ?   920           
  Branches          ?    15           
======================================
  Hits              ?   690           
  Misses            ?   210           
  Partials          ?    20

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3cee8d...df59ff4. Read the comment docs.

@stephaniewang526
chore: update synth config, re-generate common templates and clients
52429af 
1. update synth to use new paths
2. update synth to use new copyright header
3. update pom.xml files to have correct names and descriptions
4. update .repo-metadata.json for new urls
5. add .gitignore
6. generate common templates
7. re-generate client
@chingor13 chingor13 merged commit 32a90c4 into master Dec 5, 2019
@chingor13 chingor13 deleted the fix-pom branch December 5, 2019 23:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chingor13 chingor13 chingor13 approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@stephaniewang526 @chingor13 @googlebot