Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: new sample - Tables: Relax column #89

Merged
merged 1 commit into from Jan 9, 2020
Merged

feat: new sample - Tables: Relax column #89

merged 1 commit into from Jan 9, 2020

Conversation

stephaniewang526
Copy link
Contributor

Fixes b/147354241

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 8, 2020
@codecov
Copy link

codecov bot commented Jan 8, 2020 •
edited

Codecov Report

Merging #89 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #89   +/-   ##
=========================================
  Coverage     77.32%   77.32%           
  Complexity     1108     1108           
=========================================
  Files            73       73           
  Lines          5915     5915           
  Branches        644      645    +1     
=========================================
  Hits           4574     4574           
  Misses         1014     1014           
  Partials        327      327

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0c923a...f5955bc. Read the comment docs.

kurtisvg
kurtisvg approved these changes Jan 9, 2020
View reviewed changes
Copy link
Contributor

@kurtisvg kurtisvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of nits to think about, otherwise LGTM

samples/src/test/java/com/example/bigquery/RelaxColumnModeIT.java Show resolved Hide resolved
samples/src/main/java/com/example/bigquery/RelaxColumnMode.java Show resolved Hide resolved
@stephaniewang526 stephaniewang526 merged commit 6f95631 into googleapis:master Jan 9, 2020
@stephaniewang526 stephaniewang526 deleted the relax-col-sample branch January 9, 2020 22:04
@yoshi-automation yoshi-automation mentioned this pull request Jan 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kurtisvg kurtisvg kurtisvg approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@stephaniewang526 @kurtisvg @googlebot