Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(samples): dataset getcreatetime #866

Merged
merged 1 commit into from Oct 26, 2020
Merged

fix(samples): dataset getcreatetime #866

merged 1 commit into from Oct 26, 2020

Conversation

pmakani
Copy link
Contributor

@pmakani pmakani commented Oct 26, 2020

Fixes #848

@pmakani pmakani requested review from stephaniewang526 and a team October 26, 2020 05:33
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 26, 2020
@codecov
Copy link

codecov bot commented Oct 26, 2020 •
edited

Codecov Report

Merging #866 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #866   +/-   ##
=========================================
  Coverage     80.37%   80.37%           
  Complexity     1268     1268           
=========================================
  Files            79       79           
  Lines          6548     6548           
  Branches        750      750           
=========================================
  Hits           5263     5263           
  Misses          892      892           
  Partials        393      393

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44b9e92...be37e2c. Read the comment docs.

@product-auto-label product-auto-label bot added api: bigquery Issues related to the googleapis/java-bigquery API. samples Issues that are directly related to samples. labels Oct 26, 2020
@stephaniewang526 stephaniewang526 merged commit 992baaf into googleapis:master Oct 26, 2020
@pmakani pmakani deleted the resource-cleanup branch October 27, 2020 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephaniewang526 stephaniewang526 stephaniewang526 approved these changes

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/java-bigquery API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dataset.getCreationTime() is returning null
2 participants
@pmakani @stephaniewang526