Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix checkstyle errors in samples module #681

Closed
stephaniewang526 opened this issue Aug 19, 2020 · 0 comments · Fixed by #682
Closed

Fix checkstyle errors in samples module #681

stephaniewang526 opened this issue Aug 19, 2020 · 0 comments · Fixed by #682
Assignees
Labels
api: bigquery Issues related to the googleapis/java-bigquery API. type: docs Improvement to the documentation for an API.

Comments

@stephaniewang526
Copy link
Contributor

Errors: https://github.com/googleapis/java-bigquery/pull/680/checks?check_run_id=1000480840

Reproduce locally:
cd samples
mvn -P lint --quiet --batch-mode checkstyle:check

There are 88 checkstyle violations to be fixed.

@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/java-bigquery API. label Aug 19, 2020
@stephaniewang526 stephaniewang526 added the type: docs Improvement to the documentation for an API. label Aug 19, 2020
gcf-merge-on-green bot pushed a commit that referenced this issue Aug 19, 2020
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
- [X] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/java-bigquery/issues/new/choose) before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
- [X] Ensure the tests and linter pass
- [X] Code coverage does not decrease (if any source code was changed)
- [X] Appropriate docs were updated (if necessary)

Fixes #681
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/java-bigquery API. type: docs Improvement to the documentation for an API.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants