Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(samples): add query external sheet temp table #659

Merged

Conversation

pmakani
Copy link
Contributor

@pmakani pmakani commented Aug 7, 2020

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@pmakani pmakani requested review from stephaniewang526 and a team August 7, 2020 15:55
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 7, 2020
@codecov
Copy link

codecov bot commented Aug 7, 2020

Codecov Report

Merging #659 into master will decrease coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #659      +/-   ##
============================================
- Coverage     81.49%   81.35%   -0.15%     
  Complexity     1226     1226              
============================================
  Files            77       77              
  Lines          6220     6220              
  Branches        691      685       -6     
============================================
- Hits           5069     5060       -9     
- Misses          792      797       +5     
- Partials        359      363       +4     
Impacted Files Coverage Δ Complexity Δ
...n/java/com/google/cloud/bigquery/BigQueryImpl.java 82.54% <0.00%> (-1.05%) 74.00% <0.00%> (ø%)
...ogle/cloud/bigquery/WriteChannelConfiguration.java 86.36% <0.00%> (-0.46%) 46.00% <0.00%> (ø%)
...om/google/cloud/bigquery/LoadJobConfiguration.java 92.83% <0.00%> (-0.38%) 56.00% <0.00%> (ø%)
...m/google/cloud/bigquery/QueryJobConfiguration.java 89.80% <0.00%> (-0.28%) 66.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 319b982...0ab055c. Read the comment docs.

@stephaniewang526 stephaniewang526 merged commit 9044050 into googleapis:master Aug 7, 2020
@pmakani pmakani deleted the query_external_sheets_temp branch August 10, 2020 09:55
gcf-merge-on-green bot pushed a commit that referenced this pull request Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants