Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(samples): add delete dataset and contents #629

Merged
merged 1 commit into from Jul 31, 2020

Conversation

pmakani
Copy link
Contributor

@pmakani pmakani commented Jul 31, 2020

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@pmakani pmakani requested review from stephaniewang526 and a team July 31, 2020 12:36
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 31, 2020
@codecov
Copy link

codecov bot commented Jul 31, 2020

Codecov Report

Merging #629 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #629      +/-   ##
============================================
+ Coverage     81.45%   81.49%   +0.04%     
- Complexity     1225     1226       +1     
============================================
  Files            77       77              
  Lines          6200     6220      +20     
  Branches        677      691      +14     
============================================
+ Hits           5050     5069      +19     
- Misses          791      792       +1     
  Partials        359      359              
Impacted Files Coverage Δ Complexity Δ
...e/cloud/bigquery/testing/RemoteBigQueryHelper.java 61.40% <0.00%> (-0.42%) 6.00% <0.00%> (ø%)
...ain/java/com/google/cloud/bigquery/Clustering.java 100.00% <0.00%> (ø) 5.00% <0.00%> (ø%)
...ain/java/com/google/cloud/bigquery/PolicyTags.java 100.00% <0.00%> (ø) 6.00% <0.00%> (ø%)
...java/com/google/cloud/bigquery/BigtableColumn.java 100.00% <0.00%> (ø) 5.00% <0.00%> (ø%)
...java/com/google/cloud/bigquery/TimelineSample.java 100.00% <0.00%> (ø) 5.00% <0.00%> (ø%)
...om/google/cloud/bigquery/ModelTableDefinition.java 100.00% <0.00%> (ø) 4.00% <0.00%> (ø%)
...om/google/cloud/bigquery/LoadJobConfiguration.java 93.20% <0.00%> (+0.02%) 56.00% <0.00%> (ø%)
...ogle/cloud/bigquery/WriteChannelConfiguration.java 86.81% <0.00%> (+0.06%) 46.00% <0.00%> (ø%)
...google/cloud/bigquery/StandardTableDefinition.java 93.33% <0.00%> (+0.09%) 16.00% <0.00%> (ø%)
...om/google/cloud/bigquery/BigtableColumnFamily.java 96.00% <0.00%> (+0.16%) 5.00% <0.00%> (ø%)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d71720...d910a84. Read the comment docs.

@stephaniewang526 stephaniewang526 merged commit 209d035 into googleapis:master Jul 31, 2020
@pmakani pmakani deleted the delete-force-dataset branch August 3, 2020 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants