feat: add samples #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #44 +/- ##
============================================
- Coverage 77.36% 77.32% -0.04%
- Complexity 1107 1108 +1
============================================
Files 73 73
Lines 5911 5915 +4
Branches 645 645
============================================
+ Hits 4573 4574 +1
- Misses 1012 1014 +2
- Partials 326 327 +1
Continue to review full report at Codecov.
|
pmakani
reviewed
Dec 18, 2019
pmakani
approved these changes
Dec 18, 2019
kurtisvg
reviewed
Dec 18, 2019
|
|
||
| public static void runExtractTableToJSON() { | ||
| // TODO(developer): Replace these variables before running the sample. | ||
| Table table = null; |
There was a problem hiding this comment.
Why is this null? We should be showing the user how to initialize this value.
There was a problem hiding this comment.
My initial thought is user should be able to pass in a Table object of their choice to extract into GCS as CSV - but I think what you said makes sense too. We can offer an example of what this Table object could be.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes b/146347707, b/146452106