docs(samples): Convert tightly coupled local variable inside of method into method arguments #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rguments. As of the current version we can see that newExpirationTime, however by passing it as an argument engineer can easily change the newExperirationime in the IT test thus enable them to understand more about the concept.
…ments in AddColumnLoadAppendIT As of the current version we can see that the sourceUri and schema is tightly coupled with the function, meanwhile the user can pass newSchema and sourceUri base on the main method.
…ments in LoadParquetIT As of the current version we can see that the sourceUri and tableName is tightly coupled with the function, meanwhile the user can pass tableName and sourceUri base on the main method.
…ments in LoadParquetReplaceTableIT As of the current version we can see that the sourceUri and tableName is tightly coupled with the function, meanwhile the user can pass tableName and sourceUri base on the main method.
…eInsertRowsIT As of the current version we can see that the rowContent is tightly coupled with the function, meanwhile the user can pass rowContent based on the main method.
…dateDatasetAccessIT As of the current version we can see that the newEntry ACL is tightly coupled with the function, meanwhile the user can pass newEntry ACL in the main method.
…pdateTableExpirationIT As of the current version we can see that the newExpiration is tightly coupled with the function, meanwhile the user can pass newExpiration in the main method.
googlebot
added
the
cla: yes
irvifa
changed the title
irvifa
changed the title
Codecov Report
@@ Coverage Diff @@
## master #386 +/- ##
=========================================
Coverage 77.88% 77.88%
Complexity 1184 1184
=========================================
Files 77 77
Lines 6218 6218
Branches 691 690 -1
=========================================
Hits 4843 4843
Misses 1021 1021
Partials 354 354 Continue to review full report at Codecov.
|
stephaniewang526
approved these changes
May 26, 2020
stephaniewang526
added
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Jun 1, 2020
🤖 I have created a release \*beep\* \*boop\* --- ### [1.116.1](https://www.github.com/googleapis/java-bigquery/compare/v1.116.0...v1.116.1) (2020-06-01) ### Dependencies * remove google-cloud-core classiier=test since it is managed by … ([#396](https://www.github.com/googleapis/java-bigquery/issues/396)) ([bafd8ae](https://www.github.com/googleapis/java-bigquery/commit/bafd8ae780121ee968bca7b3eb68bb0f0a438124)) * restrict -annotation deps ([#402](https://www.github.com/googleapis/java-bigquery/issues/402)) ([db41581](https://www.github.com/googleapis/java-bigquery/commit/db4158186b99d0bed68fd70bef5918b1820e5dd1)) * update dependency com.google.cloud:google-cloud-shared-dependencies to v0.6.0 ([#392](https://www.github.com/googleapis/java-bigquery/issues/392)) ([3f13ccb](https://www.github.com/googleapis/java-bigquery/commit/3f13ccbbf1ca8f179c48a69c8e456bdf45c43af5)) * update shared-deps and add back certain test deps ([#390](https://www.github.com/googleapis/java-bigquery/issues/390)) ([7e21be2](https://www.github.com/googleapis/java-bigquery/commit/7e21be2506cdaf065cd32e3aed403890929b93e7)) ### Documentation * **samples:** Convert tightly coupled local variable inside of method into method arguments ([#386](https://www.github.com/googleapis/java-bigquery/issues/386)) ([7c02cd3](https://www.github.com/googleapis/java-bigquery/commit/7c02cd3ca7238d24bb2914ae2262a3b2e2d4bda7)), closes [#387](https://www.github.com/googleapis/java-bigquery/issues/387) * **samples:** Convert tightly coupled local variable involved options inside of method into method arguments ([#393](https://www.github.com/googleapis/java-bigquery/issues/393)) ([a11f3cb](https://www.github.com/googleapis/java-bigquery/commit/a11f3cb4733215a9c4a65936b05f9cc2ed75656f)), closes [#394](https://www.github.com/googleapis/java-bigquery/issues/394) * **samples:** Fix flaky test ([#397](https://www.github.com/googleapis/java-bigquery/issues/397)) ([64847d1](https://www.github.com/googleapis/java-bigquery/commit/64847d1e5137e811e7f462fc058908fa9fcc55fb)) * **samples:** update revierwers for samples module changes ([#401](https://www.github.com/googleapis/java-bigquery/issues/401)) ([69b9d84](https://www.github.com/googleapis/java-bigquery/commit/69b9d8417d5b910286aaa855f4a83fc151a81cec)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the previous PR #382 and #379.
I find several other samples that have the tendencies of including tightly coupled
variable for each of specific method. Hence I think it will be better to pass it as an argument instead of simply using local variable inside of the method.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #387 ☕️