Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't throw exception in BigQueryResultSet.close() #2832

Open
SButterfly opened this issue Jul 31, 2023 · 0 comments · May be fixed by #2833
Open

Don't throw exception in BigQueryResultSet.close() #2832

SButterfly opened this issue Jul 31, 2023 · 0 comments · May be fixed by #2833
Labels
api: bigquery Issues related to the googleapis/java-bigquery API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@SButterfly
Copy link

Is your feature request related to a problem? Please describe.
Connection.execute*() nethods return BigQueryResult, which contains BigQueryResultSet the inheritor of ResultSet.
Most of the methods of BigQueryResultSet are not implemented including close().
Unfortunately, IntelliJ Idea strongly suggests wrapping ResultSet into try-with-resources block, which we can't do because it will trow an exception.

Describe the solution you'd like
Don't throw 'Not implemented' exception in the close method.

Describe alternatives you've considered
Fully implement close method to free underlying resources.

Additional context
IntelliJ Idea's waring:
image
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/java-bigquery API. label Jul 31, 2023
@SButterfly SButterfly linked a pull request Jul 31, 2023 that will close this issue
Open
@obada-ab obada-ab added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/java-bigquery API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't throw exception in AbstractJdbcResultSet.close method SButterfly/java-bigquery
2 participants
@SButterfly @obada-ab