Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More informative parameter name or javadoc for QueryParameterValue#timestamp #2709

Open
gabor-farkas opened this issue May 22, 2023 · 0 comments
Open

More informative parameter name or javadoc for QueryParameterValue#timestamp #2709

gabor-farkas opened this issue May 22, 2023 · 0 comments
Labels
api: bigquery Issues related to the googleapis/java-bigquery API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@gabor-farkas
Copy link

The method QueryParameterValue#timestamp doesn't give a code author a clue what kind of value is expected there.
It might be considered 'common knowledge' that BigQuery works with epoch microseconds here, but it would still be nice to give a hint here, either by using the paramter name epochMicros or giving a hint in the javadoc.
Thanks
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/java-bigquery API. label May 22, 2023
@Neenu1995 Neenu1995 added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p3 Desirable enhancement or fix. May not be included in next release. labels Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/java-bigquery API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gabor-farkas @Neenu1995