Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allUsers access #178

Merged
merged 1 commit into from Feb 19, 2020
Merged

fix: allUsers access #178

merged 1 commit into from Feb 19, 2020

Conversation

pmakani
Copy link
Contributor

@pmakani pmakani commented Feb 19, 2020

Fixes #176

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 19, 2020
@codecov
Copy link

codecov bot commented Feb 19, 2020

Codecov Report

Merging #178 into master will decrease coverage by 0.17%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #178      +/-   ##
============================================
- Coverage     77.41%   77.23%   -0.18%     
+ Complexity     1114     1113       -1     
============================================
  Files            73       73              
  Lines          5941     5939       -2     
  Branches        636      626      -10     
============================================
- Hits           4599     4587      -12     
- Misses         1012     1022      +10     
  Partials        330      330              
Impacted Files Coverage Δ Complexity Δ
...com/google/cloud/bigquery/StandardSQLDataType.java 73.68% <0.00%> (-1.32%) 7.00% <0.00%> (ø%)
...m/google/cloud/bigquery/StandardSQLStructType.java 84.61% <0.00%> (-1.10%) 5.00% <0.00%> (ø%)
...ava/com/google/cloud/bigquery/RoutineArgument.java 85.71% <0.00%> (-0.65%) 5.00% <0.00%> (ø%)
...google/cloud/bigquery/ExternalTableDefinition.java 56.38% <0.00%> (-0.46%) 16.00% <0.00%> (ø%)
...va/com/google/cloud/bigquery/StandardSQLField.java 90.47% <0.00%> (-0.44%) 7.00% <0.00%> (ø%)
...java/com/google/cloud/bigquery/ViewDefinition.java 87.09% <0.00%> (-0.41%) 11.00% <0.00%> (ø%)
...y/src/main/java/com/google/cloud/bigquery/Job.java 84.67% <0.00%> (-0.23%) 32.00% <0.00%> (-1.00%)
...om/google/cloud/bigquery/BigtableColumnFamily.java 95.83% <0.00%> (-0.17%) 5.00% <0.00%> (ø%)
...google/cloud/bigquery/StandardTableDefinition.java 93.67% <0.00%> (-0.08%) 16.00% <0.00%> (ø%)
...ogle/cloud/bigquery/WriteChannelConfiguration.java 85.43% <0.00%> (-0.08%) 44.00% <0.00%> (ø%)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 646c2b4...10f734c. Read the comment docs.

@athakor athakor added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 19, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 19, 2020
@stephaniewang526 stephaniewang526 merged commit 7464e23 into googleapis:master Feb 19, 2020
@pmakani pmakani deleted the acl-176 branch February 24, 2020 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exception while describing dataset through SDK when allUsers access has been set
5 participants