feat: add support for transactioninfo in query statistics #1497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
the
api: bigquery
shollyman
approved these changes
Aug 10, 2021
| @@ -2219,6 +2220,27 @@ public void testDmlStatistics() throws InterruptedException { | |||
| assertEquals(2L, statistics.getDmlStats().getUpdatedRowCount().longValue()); | |||
| } | |||
|
|
|||
| @Test | |||
| public void testTransactionInfo() throws InterruptedException { | |||
| String tableName = TABLE_ID_FASTQUERY.getTable(); | |||
There was a problem hiding this comment.
Do you need to worry about test ordering, or is this created in a setup?
There was a problem hiding this comment.
Thank you for pointing this out. Yes, this is fine since the later test case will still update the table given the WHERE TRUE condition.
stephaniewang526
added
the
automerge
|
Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot. |
gcf-merge-on-green
bot
removed
the
automerge
Fixes googleapis#1467 revert back unrelated change
trigger github actions remove breakline lint
stephaniewang526
force-pushed
the
transactioninfo-support
branch
from
f814367
to
72aad98
Compare
stephaniewang526
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1467