BigQuery:Java:Examples Incorrect example for setting expiration for the table

[mixermt]

Hi,

There is a small, but a misleading, bug in examples on how to set an expiration for the table in Java.

https://cloud.google.com/bigquery/docs/managing-tables#updating_a_tables_expiration_time

Relevant code:

java-bigquery/samples/snippets/src/main/java/com/example/bigquery/UpdateTableExpiration.java

Line 33 in fa998ba

Long newExpiration = TimeUnit.MILLISECONDS.convert(1, TimeUnit.DAYS);

Expiration is shown in pure milliseconds of time and not in milliseconds since the epoch like stated in method documentation.

Instead, the example should use:

Long newExpiration = TimeUnit.MILLISECONDS.convert(1, TimeUnit.DAYS) + ZonedDateTime.now(ZoneOffset.UTC).toInstant().toEpochMilli();

or simple

Long newExpiration = TimeUnit.MILLISECONDS.convert(1, TimeUnit.DAYS) + System.currentTimeMillis();

Environment details

1. OS type and version: Any
2. Java version: 8
3. bigquery version(s): 1.133.0

Steps to reproduce

1. Just try an example and your table will disappear because the expiration date will be in the past