Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for javascript UDFs determinism level #1094

Merged
merged 3 commits into from Feb 9, 2021
Merged

feat: add support for javascript UDFs determinism level #1094

merged 3 commits into from Feb 9, 2021
+75 −9

Conversation

stephaniewang526
Copy link
Contributor

Fixes #1083

@stephaniewang526 stephaniewang526 requested a review from a team February 8, 2021 20:06
@stephaniewang526 stephaniewang526 requested a review from a team as a code owner February 8, 2021 20:06
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Feb 8, 2021
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/java-bigquery API. label Feb 8, 2021
@codecov
Copy link

codecov bot commented Feb 8, 2021 •
edited

Codecov Report

Merging #1094 (92883f9) into master (ef669df) will decrease coverage by 0.00%.
The diff coverage is 77.77%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1094      +/-   ##
============================================
- Coverage     80.18%   80.17%   -0.01%     
- Complexity     1268     1270       +2     
============================================
  Files            79       79              
  Lines          6576     6629      +53     
  Branches        760      766       +6     
============================================
+ Hits           5273     5315      +42     
- Misses          910      916       +6     
- Partials        393      398       +5
Impacted Files Coverage Δ Complexity Δ
.../java/com/google/cloud/bigquery/JobStatistics.java 89.45% <71.42%> (-1.86%) 16.00 <0.00> (ø)
...c/main/java/com/google/cloud/bigquery/Routine.java 81.81% <100.00%> (+0.68%) 12.00 <0.00> (ø)
...in/java/com/google/cloud/bigquery/RoutineInfo.java 92.48% <100.00%> (+1.42%) 25.00 <1.00> (+2.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef669df...0b6858d. Read the comment docs.

@stephaniewang526 stephaniewang526 added the automerge Merge the pull request once unit tests and other checks pass. label Feb 9, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit cf68d8d into googleapis:master Feb 9, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shollyman shollyman shollyman approved these changes

@steffnay steffnay Awaiting requested review from steffnay

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/java-bigquery API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BigQuery feature: support determinism level for javascript UDFs
2 participants
@stephaniewang526 @shollyman