Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BigQuery feature: support determinism level for javascript UDFs #1083

Closed
shollyman opened this issue Feb 1, 2021 · 0 comments · Fixed by #1094
Closed

BigQuery feature: support determinism level for javascript UDFs #1083

shollyman opened this issue Feb 1, 2021 · 0 comments · Fixed by #1094
Assignees
Labels
api: bigquery Issues related to the googleapis/java-bigquery API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@shollyman
Copy link
Contributor

Summary

Ensure BigQuery client library supports the ability for a javascript UDF (exposed via the Routine resource) to communicate determinism level.

The functionality here is to allow users to inform the query engine about whether a function is deterministic or not, which can improve query performance. Existing clients should already support the routines methods and resource type, so this should largely be a case of exposing a new field of the Routine and updating existing testing.

For integration testing, please note that only javascript UDFs allow determinism to be set; the backend will likely error when you try to set determinism for SQL UDFs or stored procedures.

References

Public REST reference includes information about the routine resource structure:

https://cloud.google.com/bigquery/docs/reference/rest/v2/routines#resource:-routine

Here's an example implementation that adds a new field to the Routine resource type in Go:

googleapis/google-cloud-go#3534

@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/java-bigquery API. label Feb 1, 2021
@shollyman shollyman added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Feb 1, 2021
@stephaniewang526 stephaniewang526 self-assigned this Feb 2, 2021
stephaniewang526 added a commit to stephaniewang526/java-bigquery that referenced this issue Feb 8, 2021
stephaniewang526 added a commit to stephaniewang526/java-bigquery that referenced this issue Feb 9, 2021
Fixes googleapis#1083

fix missing returnType in request

update integration test case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/java-bigquery API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants