From e6441cc2c7c1db3926d7dd0883ba7faaf61ee74e Mon Sep 17 00:00:00 2001 From: Irvi Firqotul Aini Date: Fri, 29 May 2020 00:45:01 +0700 Subject: [PATCH] docs(samples): Fix flaky test We found that UpdateTableExpirationIT is flaky since during table creation the table is not created. --- .../com/example/bigquery/UpdateTableExpirationIT.java | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/samples/snippets/src/test/java/com/example/bigquery/UpdateTableExpirationIT.java b/samples/snippets/src/test/java/com/example/bigquery/UpdateTableExpirationIT.java index 4283170291..1551d21e25 100644 --- a/samples/snippets/src/test/java/com/example/bigquery/UpdateTableExpirationIT.java +++ b/samples/snippets/src/test/java/com/example/bigquery/UpdateTableExpirationIT.java @@ -19,6 +19,9 @@ import static com.google.common.truth.Truth.assertThat; import static junit.framework.TestCase.assertNotNull; +import com.google.cloud.bigquery.Field; +import com.google.cloud.bigquery.Schema; +import com.google.cloud.bigquery.StandardSQLTypeName; import java.io.ByteArrayOutputStream; import java.io.PrintStream; import java.util.concurrent.TimeUnit; @@ -59,7 +62,11 @@ public void tearDown() { @Test public void updateTableExpiration() { String tableName = "update_expiration_table"; - CreateTable.createTable(BIGQUERY_DATASET_NAME, tableName, null); + Schema schema = + Schema.of( + Field.of("stringField", StandardSQLTypeName.STRING), + Field.of("booleanField", StandardSQLTypeName.BOOL)); + CreateTable.createTable(BIGQUERY_DATASET_NAME, tableName, schema); Long newExpiration = TimeUnit.MILLISECONDS.convert(1, TimeUnit.DAYS); UpdateTableExpiration.updateTableExpiration(BIGQUERY_DATASET_NAME, tableName, newExpiration); assertThat(bout.toString()).contains("Table expiration updated successfully");