fix: upload download instances are not marked invalid with retriable error codes #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cojenco
added
the
do not merge
product-auto-label
bot
added
the
api: storage
google-cla
bot
added
the
cla: yes
tseaver
suggested changes
Aug 30, 2021
cojenco
removed
the
do not merge
tseaver
approved these changes
Aug 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ResumableUploadandChunkedDownloadcan retry when it is safe to do so (encountering retriable error codes and specify preconditions if needed). The instance should not be marked as invalid if it encounters a retriable status code.Update helper method
require_status_code()to only make an instance invalid with non-retriable error codes.