Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: drop Python 2.7 support #229

Merged
merged 20 commits into from Aug 2, 2021
Merged

fix!: drop Python 2.7 support #229

merged 20 commits into from Aug 2, 2021

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Jun 16, 2021

  • Drop six.
  • Drop u" prefixes for text strings.

Release-As: 2.0.0b1

Closes #228.

@tseaver
fix!: drop support for Python 2.7.
56b2bd1 
Release-As: 2.0.0b1

Closes #228.
@tseaver
chore: drop use of 'six' wrapper
6541630
@tseaver
chore: drop 'u"' prefixes
29aa7df 
Via:

    $ for f in $(git grep -l 'u"' google/ tests/ tests_async/); do
    >     echo $f
    >     sed -i -e 's/\<u"/"/g' $f
    > done
@tseaver tseaver requested a review from a team as a code owner June 16, 2021 17:36
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/google-resumable-media-python API. label Jun 16, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jun 16, 2021
@tseaver tseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 16, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 16, 2021
@tseaver tseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 16, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 16, 2021
plamut
plamut suggested changes Jun 17, 2021
View reviewed changes
Copy link
Contributor

@plamut plamut left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits, but the major thing is the incorrect import. And maybe changes in test image files need to be reverted. Otherwise looks good.

README.rst Show resolved Hide resolved
tests/system/requests/test_upload.py Outdated Show resolved Hide resolved
google/_async_resumable_media/__init__.py Show resolved Hide resolved
tests/unit/test__download.py Outdated Show resolved Hide resolved
@tseaver tseaver mentioned this pull request Jun 18, 2021
Merged
plamut
plamut reviewed Jun 18, 2021
View reviewed changes
Copy link
Contributor

@plamut plamut left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The six pin sneaked back into constraints-3.6.txt after merging the latest master. When that is removed, I think we are good to go.

Edit: Ugh, and that urllib_parse import again for some reason... (ah, it's actually still there, it was not fixed in all files)

@plamut
Copy link
Contributor

plamut commented Jun 18, 2021

I have nothing more to add, thanks for this cleanup!

@tseaver tseaver added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jun 18, 2021
@tseaver
Copy link
Contributor Author

tseaver commented Jun 18, 2021

Marked as do not merge pending discussion over the versioning policy next week with @busunkim96, @crwilcox, et al.

@tseaver tseaver added the semver: major Hint for users that this is an API breaking change. label Jul 14, 2021
@tseaver tseaver removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 2, 2021
@tseaver tseaver merged commit af10d4b into googleapis:master Aug 2, 2021
This was referenced Aug 2, 2021
Merged
Closed
@tseaver tseaver deleted the 228-drop-python-2.7 branch August 2, 2021 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plamut plamut plamut approved these changes

@crwilcox crwilcox Awaiting requested review from crwilcox

@andrewsg andrewsg Awaiting requested review from andrewsg

@busunkim96 busunkim96 Awaiting requested review from busunkim96

Assignees
No one assigned
Labels
api: storage Issues related to the googleapis/google-resumable-media-python API. cla: yes This human has signed the Contributor License Agreement. semver: major Hint for users that this is an API breaking change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Drop Python 2.7 support
3 participants
@tseaver @plamut @yoshi-kokoro