feat: allow RetryStrategy to be configured with a custom initial wait and multiplier #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: storage
google-cla
bot
added
the
cla: yes
tseaver
suggested changes
May 10, 2021
andrewsg
force-pushed
the
retry-unification
branch
from
213500e
to
a18c79d
Compare
|
@tseaver thanks, PTAL |
tseaver
suggested changes
May 18, 2021
tseaver
reviewed
May 18, 2021
andrewsg
force-pushed
the
retry-unification
branch
from
a18c79d
to
f2f01f4
Compare
tseaver
approved these changes
May 18, 2021
tritone
approved these changes
May 18, 2021
| @@ -195,6 +203,41 @@ def test_success_with_retry(self, randint_mock, sleep_mock): | |||
| sleep_mock.assert_any_call(2.625) | |||
| sleep_mock.assert_any_call(4.375) | |||
|
|
|||
| @mock.patch(u"time.sleep") | |||
| @mock.patch(u"random.randint") | |||
| def test_success_with_retry_custom_delay(self, randint_mock, sleep_mock): | |||
| base_wait, wait_time = calculate_retry_wait(base_wait, retry_strategy.max_sleep) | ||
| base_wait, wait_time = calculate_retry_wait( | ||
| base_wait, retry_strategy.max_sleep, retry_strategy.multiplier | ||
| ) |
There was a problem hiding this comment.
Kind of surprising that this is all calculated in the library rather than using a helper (in Go we use gax) but obviously nothing to address here.
There was a problem hiding this comment.
Strong agree. We have such a helper for python-storage but because the transport layer is different I couldn't simply replace the implementation here with that helper. In the future I'd like to do a bit more work to bring resumable media into the fold in terms of unifying its behavior with python-storage and BQ.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backwards-compatible change to allow the python-storage client to configure retries in media calls similarly to how it configures retries in API calls.