Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: address terminology #201

Merged
merged 5 commits into from Feb 13, 2021
Merged

docs: address terminology #201

merged 5 commits into from Feb 13, 2021

Conversation

frankyn
Copy link
Member

@frankyn frankyn commented Feb 10, 2021

Address terminology.

@frankyn frankyn requested a review from a team as a code owner February 10, 2021 17:47
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Feb 10, 2021
@frankyn frankyn added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 12, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 12, 2021
@frankyn
Copy link
Member Author

frankyn commented Feb 12, 2021

@busunkim96 do you know why Kokoro docs-presubmit would fail? There's no result in kokoro and I've ran both lint and docs through nox locally with both passing.

@frankyn
Copy link
Member Author

frankyn commented Feb 12, 2021

Missing a config per @busunkim96, ignoring docs-presubmit. Just need a review.

@frankyn frankyn merged commit a88cfb9 into master Feb 13, 2021
@frankyn frankyn deleted the address-terminology branch February 13, 2021 00:23
@tseaver tseaver mentioned this pull request Aug 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewsg andrewsg andrewsg approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@frankyn @andrewsg @yoshi-kokoro