feat: add configurable crc32c checksumming for downloads #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
Received a design suggestion to move the argument to the class constructor for the download class; looking into refactoring that now. |
frankyn
requested changes
Jun 25, 2020
|
@frankyn PTAL |
|
Fixed merge conflict and addressed comments. |
frankyn
requested changes
Jun 29, 2020
|
Thanks for the suggestion, I was able to remove some duplication of code between Download and RawDownload and tighten it up a bit in general. PTAL |
frankyn
requested changes
Jul 1, 2020
|
@frankyn fixed coverage issue; PTAL |
frankyn
approved these changes
Jul 7, 2020
There was a problem hiding this comment.
LGTM, thanks @andrewsg,
pending kokoro failure:
Formatting issue:
flake8 google/resumable_media tests
black --check google/resumable_media tests
would reformat /tmpfs/src/github/google-resumable-media-python/tests/unit/requests/test_download.py
Oh no! 💥 💔 💥
1 file would be reformatted, 24 files would be left unchanged.
3 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.