Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HttpResponse uses contains where it needs equals #842

Closed
elharo opened this issue Oct 14, 2019 · 0 comments · Fixed by #843
Closed

HttpResponse uses contains where it needs equals #842

elharo opened this issue Oct 14, 2019 · 0 comments · Fixed by #843
Assignees
@chingor13
Labels
good first issue This issue is a good place to started contributing to this repository. help wanted We'd love to have community involvement on this issue. priority: p2 Moderately-important priority. Fix may not be included in next release. semver: patch A minor bug fix or small change. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@elharo
Copy link
Contributor

elharo commented Oct 14, 2019 •
edited 

        if (!returnRawInputStream
             && contentEncoding != null	              && contentEncoding != null
             && contentEncoding.contains("gzip")) {

"contains" is incorrect. This should be equals or perhaps equalsIgnoreCase with a trim, or something like that. However it shouldn't fire on foogzipbar.
@elharo elharo added good first issue This issue is a good place to started contributing to this repository. help wanted We'd love to have community involvement on this issue. priority: p2 Moderately-important priority. Fix may not be included in next release. semver: patch A minor bug fix or small change. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Oct 14, 2019
@elharo elharo mentioned this issue Oct 14, 2019
Merged
egsavage added a commit to egsavage/google-http-java-client that referenced this issue Oct 14, 2019
@egsavage
Issue googleapis#842 - HttpResponse GZip content encoding equality ch…
5f39135 
…ange
@egsavage egsavage mentioned this issue Oct 14, 2019
Merged
egsavage added a commit to egsavage/google-http-java-client that referenced this issue Oct 19, 2019
@egsavage
Issue googleapis#842 - Added unit test, PR updates
af5b469
egsavage added a commit to egsavage/google-http-java-client that referenced this issue Oct 20, 2019
@egsavage
Issue googleapis#842 - Adjusted spacing, dropped ignoreCase on compar…
2cc4fe7 
…ison
egsavage added a commit to egsavage/google-http-java-client that referenced this issue Oct 27, 2019
@egsavage
Issue googleapis#842 - Enforce locale on encoding comparison, add uni…
beeac46 
…t tests
egsavage added a commit to egsavage/google-http-java-client that referenced this issue Oct 27, 2019
@egsavage
Issue googleapis#842 - Removed final, fixed spelling
abda56b
egsavage added a commit to egsavage/google-http-java-client that referenced this issue Oct 29, 2019
@egsavage
Issue googleapis#842 - test updates
80aa603
chingor13 pushed a commit that referenced this issue Oct 29, 2019
@egsavage @chingor13
fix: HttpResponse GZip content encoding equality change (#843)
9c73e1d 
* Issue #842 - HttpResponse GZip content encoding equality change

* Issue #842 - Added unit test, PR updates

* Issue #842 - Adjusted spacing, dropped ignoreCase on comparison

* Issue #842 - Enforce locale on encoding comparison, add unit tests

* Issue #842 - Removed final, fixed spelling

* Issue #842 - test updates
clundin25 pushed a commit to clundin25/google-http-java-client that referenced this issue Aug 11, 2022
@renovate-bot
chore(deps): update actions/github-script action to v5 (googleapis#842)
05cba2f 
[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [actions/github-script](https://togithub.com/actions/github-script) | action | major | `v3` -> `v5` |

---

### Release Notes

<details>
<summary>actions/github-script</summary>

### [`v5`](https://togithub.com/actions/github-script/compare/v4...v5)

[Compare Source](https://togithub.com/actions/github-script/compare/v4...v5)

### [`v4`](https://togithub.com/actions/github-script/compare/v3...v4)

[Compare Source](https://togithub.com/actions/github-script/compare/v3...v4)

</details>

---

### Configuration

📅 **Schedule**: At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/google-auth-library-java).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chingor13 chingor13

Labels
good first issue This issue is a good place to started contributing to this repository. help wanted We'd love to have community involvement on this issue. priority: p2 Moderately-important priority. Fix may not be included in next release. semver: patch A minor bug fix or small change. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: HttpResponse GZip content encoding equality change egsavage/google-http-java-client
2 participants
@chingor13 @elharo