Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Micrometer Observation Support #1868

Open
marcingrzejszczak opened this issue Jul 19, 2023 · 2 comments · May be fixed by #1879
Open

Micrometer Observation Support #1868

marcingrzejszczak opened this issue Jul 19, 2023 · 2 comments · May be fixed by #1879
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@marcingrzejszczak
Copy link

I'm a co-maintainer of Spring Cloud Sleuth and Micrometer projects (together with @shakuzen and @jonatan-ivanov).

Micrometer Observation is part of the Micrometer 1.10 release and Micrometer Tracing is a new project. The idea of Micrometer Observation is that you instrument code once but you get multiple benefits out of it - e.g. you can get tracing, metrics, logging or whatever you see fit).

Since this project supports OpenCensus that is deprecated I was curious if there's interest in adding Micrometer Observation support so that except for metrics, spans could be created and tracing context propagation could happen too. Via Micrometer Tracing one can use OpenTelemetry or OpenZipkin Brave Tracer, but with the handler mechanism the possibilities are endless :)

If there's such interest we could provide a PR to add support for that.
@marcingrzejszczak marcingrzejszczak linked a pull request Sep 15, 2023 that will close this issue
Draft
4 tasks
@marcingrzejszczak
Copy link
Author

Hey I've created a draft PR #1879 where we could discuss how this could theoretically look like.

@blakeli0 blakeli0 added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p3 Desirable enhancement or fix. May not be included in next release. labels Sep 26, 2023
@blakeli0
Copy link

Hi @marcingrzejszczak, thanks for opening the issue! Migrating from OpenCensus to OpenTelemetry is in our long term vision but not in the near future, and adding Micrometer is not on our roadmap at this moment either.
If you are interested, you can take a look at the possibility of adding Micrometer support to gax-java, which is the runtime dependency for all the Google Cloud Client libraries.
We don't have plans to add Micrometer to gax-java at this moment either, but it is being more actively maintained and the possibility of having Micrometer support is higher. In addition, I have a PoC code for adding OpenTelemetry support to gax-java, which may give you some ideas.

@marcingrzejszczak marcingrzejszczak mentioned this issue Sep 27, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Micrometer Observation support marcingrzejszczak/google-http-java-client
2 participants
@marcingrzejszczak @blakeli0