feat: add AttemptCount to HttpResponseException #1505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
TimurSadykov
commented
Nov 19, 2021
| /** | ||
| * Returns the attempt count | ||
| * | ||
| * @since 1.41 |
There was a problem hiding this comment.
not sure if i need to add this manually
lesv
approved these changes
Nov 19, 2021
ejona86
added a commit
to ejona86/grpc-java
that referenced
this pull request
Apr 27, 2022
This reverts commit 0963f31. This causes dependency problems when importing into Google, as google-auth-library-java needs to be upgraded and that requires an upgrade to google-http-java-client to bring in googleapis/google-http-java-client#1505 . Reverting for now and will roll forward once those upgrades are performed.
sergiitk
pushed a commit
to grpc/grpc-java
that referenced
this pull request
Apr 27, 2022
This reverts commit 0963f31. This causes dependency problems when importing into Google, as google-auth-library-java needs to be upgraded and that requires an upgrade to google-http-java-client to bring in googleapis/google-http-java-client#1505 . Reverting for now and will roll forward once those upgrades are performed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds number of requests attempted to httpRequestException. This makes sense to know how many attempts were made since HttpRequest supports automated retries. We want to use it to improve user experience of Auth library, that leverages HttpRequest retry functionality.
For more details on the feature: go/auth-correct-retry