Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add used packages to OSGI manifest again (#1439) #1440

Merged
merged 1 commit into from Sep 1, 2021
Merged

fix: add used packages to OSGI manifest again (#1439) #1440

merged 1 commit into from Sep 1, 2021

Conversation

danthe1st
Copy link
Contributor

@danthe1st danthe1st commented Aug 30, 2021 •
edited

This PR adds the Import-Package declarations that were lost in #1405 as I declared javax.annotation explicitely.

This is fixed by adding * to the Import-Package declaration which is the default behaviour that has been overwritten in #1405.
As javax.annotation is still (correctly) present, it is not added a second time by using *.

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)

No source Code was changed

  • Appropriate docs were updated (if necessary)

Not necessary

Fixes #1439 ☕️

@danthe1st danthe1st requested a review from a team as a code owner August 30, 2021 12:44
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 30, 2021
@lesv lesv merged commit 59fc8b0 into googleapis:master Sep 1, 2021
@danthe1st danthe1st deleted the osgi-re-add branch September 1, 2021 19:11
gcf-merge-on-green bot pushed a commit that referenced this pull request Oct 7, 2021
@release-please
chore: release 1.40.1 (#1462)
0b533c9 
🤖 I have created a release \*beep\* \*boop\*
---
### [1.40.1](https://www.github.com/googleapis/google-http-java-client/compare/v1.40.0...v1.40.1) (2021-10-07)


### Bug Fixes

* add used packages to OSGI manifest again ([#1439](https://www.github.com/googleapis/google-http-java-client/issues/1439)) ([#1440](https://www.github.com/googleapis/google-http-java-client/issues/1440)) ([59fc8b0](https://www.github.com/googleapis/google-http-java-client/commit/59fc8b03e5518864c60ce4dd47664e8935da343b))
* update NetHttpRequest to prevent silent retry of DELETE requests ([#1472](https://www.github.com/googleapis/google-http-java-client/issues/1472)) ([57ef11a](https://www.github.com/googleapis/google-http-java-client/commit/57ef11a0e1904bb932e5493a30f0a2ca2a2798cf)), closes [#1471](https://www.github.com/googleapis/google-http-java-client/issues/1471)


### Dependencies

* update dependency com.fasterxml.jackson.core:jackson-core to v2.12.5 ([#1437](https://www.github.com/googleapis/google-http-java-client/issues/1437)) ([0ce8467](https://www.github.com/googleapis/google-http-java-client/commit/0ce84676bfbe4cc8e237d5e33dfaa532b13e798c))
* update dependency com.fasterxml.jackson.core:jackson-core to v2.13.0 ([#1469](https://www.github.com/googleapis/google-http-java-client/issues/1469)) ([7d9a042](https://www.github.com/googleapis/google-http-java-client/commit/7d9a042110b8879b592d7e80bd73e77c7a84d8b7))
* update dependency com.google.protobuf:protobuf-java to v3.18.0 ([#1454](https://www.github.com/googleapis/google-http-java-client/issues/1454)) ([cc63e41](https://www.github.com/googleapis/google-http-java-client/commit/cc63e41fac8295c7fea751191a6fe9537c1f70e3))
* update dependency com.google.protobuf:protobuf-java to v3.18.1 ([#1470](https://www.github.com/googleapis/google-http-java-client/issues/1470)) ([c36637a](https://www.github.com/googleapis/google-http-java-client/commit/c36637acbca536992349970664026cf145ad8964))
* update dependency com.puppycrawl.tools:checkstyle to v9 ([#1441](https://www.github.com/googleapis/google-http-java-client/issues/1441)) ([a95cd97](https://www.github.com/googleapis/google-http-java-client/commit/a95cd9717fc8accd80252b12357971cb71887d90))
* update project.appengine.version to v1.9.91 ([#1287](https://www.github.com/googleapis/google-http-java-client/issues/1287)) ([09ebf8d](https://www.github.com/googleapis/google-http-java-client/commit/09ebf8d7e3860f2b94a6fea0ef134c93904d4ed1))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
gcf-owl-bot bot added a commit that referenced this pull request May 19, 2022
@gcf-owl-bot
feat: add build scripts for native image testing in Java 17 (#1440)
864f08f 
Source-Link: googleapis/synthtool@505ce5a
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:2567a120ce90fadb6201999b87d649d9f67459de28815ad239bce9ebfaa18a74
meltsufin pushed a commit that referenced this pull request May 19, 2022
@gcf-owl-bot
feat: add build scripts for native image testing in Java 17 (#1440) (#…
05d4019 
…1666)

Source-Link: googleapis/synthtool@505ce5a
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:2567a120ce90fadb6201999b87d649d9f67459de28815ad239bce9ebfaa18a74

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
@release-please release-please bot mentioned this pull request May 19, 2022
Merged
gcf-merge-on-green bot pushed a commit that referenced this pull request Jun 9, 2022
@release-please
chore(main): release 1.42.0 (#1631)
0e2c7e8 
🤖 I have created a release *beep* *boop*
---


## [1.42.0](v1.41.7...v1.42.0) (2022-06-09)


### Features

* add build scripts for native image testing in Java 17 ([#1440](#1440)) ([#1666](#1666)) ([05d4019](05d4019))
* next release from main branch is 1.42.0 ([#1633](#1633)) ([9acb1ab](9acb1ab))


### Dependencies

* update dependency com.fasterxml.jackson.core:jackson-core to v2.13.3 ([#1665](#1665)) ([e4f0959](e4f0959))
* update dependency com.google.errorprone:error_prone_annotations to v2.13.0 ([#1630](#1630)) ([bf777b3](bf777b3))
* update dependency com.google.errorprone:error_prone_annotations to v2.13.1 ([#1632](#1632)) ([9e46cd8](9e46cd8))
* update dependency com.google.errorprone:error_prone_annotations to v2.14.0 ([#1667](#1667)) ([3516e18](3516e18))
* update dependency com.google.protobuf:protobuf-java to v3.20.1 ([#1639](#1639)) ([90a99e2](90a99e2))
* update dependency com.google.protobuf:protobuf-java to v3.21.0 ([#1668](#1668)) ([babbe94](babbe94))
* update dependency com.google.protobuf:protobuf-java to v3.21.1 ([#1669](#1669)) ([30ec091](30ec091))
* update dependency org.apache.felix:maven-bundle-plugin to v5.1.6 ([#1643](#1643)) ([8547f5f](8547f5f))
* update project.appengine.version to v2.0.5 ([#1662](#1662)) ([2c82c0d](2c82c0d))
* update project.opencensus.version to v0.31.1 ([#1644](#1644)) ([3c65a07](3c65a07))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
clundin25 pushed a commit to clundin25/google-http-java-client that referenced this pull request Aug 11, 2022
@gcf-owl-bot
feat: add build scripts for native image testing in Java 17 (googleap…
bbb51ce 
…is#1440) (googleapis#923)

Source-Link: googleapis/synthtool@505ce5a
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:2567a120ce90fadb6201999b87d649d9f67459de28815ad239bce9ebfaa18a74
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lesv lesv lesv approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Http-Client: packages in OSGI Import-Package removed
2 participants
@danthe1st @lesv