Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSON Schema: Use Type Integer Rather Than String #125

Closed
grant opened this issue Dec 9, 2020 · 0 comments · Fixed by #127
Closed

JSON Schema: Use Type Integer Rather Than String #125

grant opened this issue Dec 9, 2020 · 0 comments · Fixed by #127
Assignees
@grant
Labels
api: eventarc Issues related to the googleapis/google-cloudevents API.

Comments

@grant
Copy link
Contributor

grant commented Dec 9, 2020

Expected Behavior

The JSON schemas should use type integer for int64 types, like with port in CAL: https://github.com/googleapis/google-cloudevents/blob/master/jsonschema/google/events/cloud/audit/v1/LogEntryData.json#L420

This was mentioned by @jskeet here: googleapis/google-cloudevents-java#54 (comment)

Actual Behavior

We use type string, which causes end libraries to not have great results.
@grant grant self-assigned this Dec 9, 2020
@product-auto-label product-auto-label bot added the api: eventarc Issues related to the googleapis/google-cloudevents API. label Dec 9, 2020
@grant grant mentioned this issue Dec 11, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@grant grant

Labels
api: eventarc Issues related to the googleapis/google-cloudevents API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

JSON schema no bigint strings googleapis/google-cloudevents
1 participant
@grant