New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: run the generator – fewer oneOf types, 12/07/2020 #54
Conversation
Signed-off-by: Grant Timmerman <timmerman+devrel@google.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy for this to be merged as the current generator results, but I'm really concerned about the types here.
src/main/java/com/google/events/cloud/audit/v1/DestinationAttributes.java
Outdated
Show resolved
Hide resolved
@@ -23,7 +23,7 @@ | |||
*/ | |||
public class StepTimeout { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we get a new class every time a google.protobuf.Duration is used, that's going to be a terrible user experience.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Started an email thread to talk about this concern.
Signed-off-by: Grant Timmerman <timmerman+devrel@google.com>
🤖 I have created a release \*beep\* \*boop\* --- ## [0.2.0](https://www.github.com/googleapis/google-cloudevents-java/compare/v0.1.5...v0.2.0) (2021-01-26) ### Features * run the generator – fewer oneOf types, 12/07/2020 ([#54](https://www.github.com/googleapis/google-cloudevents-java/issues/54)) ([615e3e7](https://www.github.com/googleapis/google-cloudevents-java/commit/615e3e72f07a2918bd68f244e537948e3aa8ec33)) ### Documentation * update doc install instructions ([#56](https://www.github.com/googleapis/google-cloudevents-java/issues/56)) ([55f551a](https://www.github.com/googleapis/google-cloudevents-java/commit/55f551a06bae742cf33c3e0346de6b7239d33b31)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Runs the generator.
This update should include: