Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update release process, remove comment #47

Merged
merged 1 commit into from Nov 13, 2020
Merged

Conversation

grant
Copy link
Contributor

@grant grant commented Nov 13, 2020

Removes a comment, which seems to not be allowable in the release script.

Comment added from this review: #44 (comment)

Fixes #40 (comment)

Signed-off-by: Grant Timmerman <timmerman+devrel@google.com>
@grant grant requested a review from grayside November 13, 2020 22:51
@grant grant requested a review from a team as a code owner November 13, 2020 22:51
@grant grant self-assigned this Nov 13, 2020
@product-auto-label product-auto-label bot added the api: eventarc Issues related to the googleapis/google-cloudevents-java API. label Nov 13, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 13, 2020
@grant grant merged commit 694dd35 into master Nov 13, 2020
@grant grant deleted the grant_release_comment branch November 13, 2020 22:55
gcf-merge-on-green bot pushed a commit that referenced this pull request Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: eventarc Issues related to the googleapis/google-cloudevents-java API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warning: a recent release failed
2 participants