From 2c69e44ce86f77b700d4c417c9a76b4c96f098b8 Mon Sep 17 00:00:00 2001 From: Grant Timmerman <744973+grant@users.noreply.github.com> Date: Fri, 13 Nov 2020 16:16:02 -0600 Subject: [PATCH] fix: skip clirr step to allow release (#44) Skip clirr check as there are known breaking changes to this artifact (when we changed generators). - Fixes: https://github.com/googleapis/google-cloudevents-java/issues/40 - Related: https://github.com/googleapis/google-cloudevents-java/issues/43 --- .github/CONTRIBUTING.md | 13 ++++++++++--- .kokoro/release/stage.sh | 1 + 2 files changed, 11 insertions(+), 3 deletions(-) diff --git a/.github/CONTRIBUTING.md b/.github/CONTRIBUTING.md index e8fbd18c..b2d09907 100644 --- a/.github/CONTRIBUTING.md +++ b/.github/CONTRIBUTING.md @@ -17,17 +17,24 @@ Then, to generate, run the ./gen.sh file in the java repo. This will generate th ./tools/gen.sh ``` -Observe the new files in `google-cloudevent-types/src/`. +Observe the new files in `src/`. ## Test -Run tests in the `google-cloudevent-types` : +Run tests: ```sh -cd google-cloudevent-types mvn test ``` +## Prepublish Checklist + +Install the library to ensure it builds correctly: + +``` +mvn install -Dclirr.skip +``` + ## How to Contribute We'd love to accept your patches and contributions to this project. There are diff --git a/.kokoro/release/stage.sh b/.kokoro/release/stage.sh index 3c482cbc..c0c88d1f 100755 --- a/.kokoro/release/stage.sh +++ b/.kokoro/release/stage.sh @@ -29,6 +29,7 @@ create_settings_xml_file "settings.xml" mvn clean install deploy -B \ --settings ${MAVEN_SETTINGS_FILE} \ -DskipTests=true \ + -Dclirr.skip \ # Ignore running clirr for breaking changes. See #43 -DperformRelease=true \ -Dgpg.executable=gpg \ -Dgpg.passphrase=${GPG_PASSPHRASE} \