Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose SchemaService in handwritten layer #9304

Closed
quartzmo opened this issue Feb 5, 2021 · 1 comment · Fixed by #9305
Closed

Expose SchemaService in handwritten layer #9304

quartzmo opened this issue Feb 5, 2021 · 1 comment · Fixed by #9305
Assignees
@quartzmo
Labels
api: pubsub Issues related to the Pub/Sub API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@quartzmo
Copy link
Member

quartzmo commented Feb 5, 2021

In google-cloud-pubsub, this support requires encapsulating the Google::Cloud::PubSub::V1::SchemaService::Client RPCs and Google::Cloud::PubSub::V1::Schema resource while adhering to OOP design principles.

Python: PR
@quartzmo quartzmo self-assigned this Feb 5, 2021
@quartzmo quartzmo added api: pubsub Issues related to the Pub/Sub API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Feb 5, 2021
@quartzmo
Copy link
Member Author

quartzmo commented Feb 5, 2021

/cc @anguillanneuf

@quartzmo quartzmo mentioned this issue Feb 8, 2021
Merged
quartzmo added a commit to quartzmo/google-cloud-ruby that referenced this issue Mar 19, 2021
@quartzmo
feat(pubsub): Add Schema support
9a74a5f 
closes: googleapis#9304
quartzmo added a commit that referenced this issue Mar 30, 2021
@quartzmo
feat(pubsub): Add Schema support
3c91de7 
* Add Schema
* Add Project#create_schema
* Add Project#schema
* Add Project#schemas (Schema::List)
* Add Project#valid_schema?
* Add schema options to Project#create_topic
* Add Topic#schema_name
* Add Topic#message_encoding
* Add Topic#message_encoding_binary?
* Add Topic#message_encoding_json?

closes: #9304
pr: #9305
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@quartzmo quartzmo

Labels
api: pubsub Issues related to the Pub/Sub API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(pubsub): Add Schema support quartzmo/google-cloud-ruby
1 participant
@quartzmo