Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BigQuery feature: support determinism level for javascript UDFs #8960

Closed
shollyman opened this issue Feb 1, 2021 · 0 comments · Fixed by #9127 or #9316
Closed

BigQuery feature: support determinism level for javascript UDFs #8960

shollyman opened this issue Feb 1, 2021 · 0 comments · Fixed by #9127 or #9316
Assignees
Labels
api: bigquery Issues related to the BigQuery API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@shollyman
Copy link

Summary

Ensure BigQuery client library supports the ability for a javascript UDF (exposed via the Routine resource) to communicate determinism level.

The functionality here is to allow users to inform the query engine about whether a function is deterministic or not, which can improve query performance. Existing clients should already support the routines methods and resource type, so this should largely be a case of exposing a new field of the Routine and updating existing testing.

For integration testing, please note that only javascript UDFs allow determinism to be set; the backend will likely error when you try to set determinism for SQL UDFs or stored procedures.

References

Public REST reference includes information about the routine resource structure:

https://cloud.google.com/bigquery/docs/reference/rest/v2/routines#resource:-routine

Here's an example implementation that adds a new field to the Routine resource type in Go:

googleapis/google-cloud-go#3534

@shollyman shollyman added api: bigquery Issues related to the BigQuery API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Feb 1, 2021
@quartzmo quartzmo self-assigned this Feb 1, 2021
quartzmo added a commit to quartzmo/google-cloud-ruby that referenced this issue Feb 3, 2021
quartzmo added a commit that referenced this issue Feb 8, 2021
quartzmo added a commit to quartzmo/google-cloud-ruby that referenced this issue Feb 9, 2021
* Add Routine#determinism_level
* Add Routine#determinism_level=
* Add Routine#determinism_level_deterministic?
* Add Routine#determinism_level_not_deterministic?
* Add Routine::Updater#determinism_level=

closes: googleapis#8960
refs: googleapis#9127
quartzmo added a commit that referenced this issue Feb 9, 2021
* Add Routine#determinism_level
* Add Routine#determinism_level=
* Add Routine#determinism_level_deterministic?
* Add Routine#determinism_level_not_deterministic?
* Add Routine::Updater#determinism_level=

closes: #8960
pr: #9127
pr: #9316
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the BigQuery API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
2 participants