Errors in storage acceptance test #11224
Assignees
Labels
api: storage
Issues related to the Cloud Storage API.
priority: p2
Moderately-important priority. Fix may not be included in next release.
🚨
This issue needs some love.
type: bug
Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Comments
dazuma
added
type: bug
|
I could not reproduce the I did reproduce the The errors come from this usage pattern: @dazuma Do you know of any reason why the hash form of the request would no longer be accepted? The |
|
The only change to |
|
Before the |
quartzmo
added a commit
to quartzmo/google-cloud-ruby
that referenced
this issue
Apr 27, 2021
… inline code samples refs: googleapis#11224
|
The However, once this problem is solved on the Ruby 2.x runs, the I am now able to reproduce the error on Ruby |
|
@frankyn Any idea why we might be seeing errors in calls to |
|
Hi @quartzmo, This has not come up (yet) in other languages. Could you log request JSON bodies for |
|
Thanks @frankyn, will do! I'll also log the unencoded |
|
@frankyn, here are the logged requests for the three different styles of request object, using Ruby 3.0.1 to avoid Style 1
HTTP request body (Update, from a later test run): Result: Works in Ruby 3.0. Causes Style 2
HTTP request body (Update, from a later test run): Result: Causes Style 3
HTTP request body (Update, from a later test run): Result: Works in all Ruby versions. |
|
Oh interesting, TIL that the Ruby gem google-api-client was split into multiple gems and mono deprecated! The PRs are very lengthy, but didn't pick up on anything that might be relevant. I referring to the following PRs:
@dazuma i'm assuming no major logic changes were made, but wondering if you may have more context. |
|
@frankyn I've been trying to find a change that caused the |
|
I also got the |
|
@quartzmo for the logs, I see that we only have response JSON body, is there an equivalent request JSON structure? BTW: Thanks for getting the additional logging!! |
|
@frankyn I wasn't able to figure out how to log the request. I can try again this evening. |
|
@frankyn I updated the logs comment above with the request bodies. It turns out that in Style 2, with the |
|
Thanks for the additional context @quartzmo! IIUC the tests and rubydoc samples should use the class data model representation instead of a Ruby Hash to construct the request payload. The request bodies are equivalent, so wondering if there's something going on the URL because it contains special characters in the URI with the Google Service account email. BTW: I'm okay with shelving this and moving forward with the PR you have open at this point to address the broken tests. |
|
I reproduced what's happening inside |
|
@frankyn Keep in mind that we didn't use Style 2 originally, we used Style 1. Which still works if you can get past the |
|
Thank you @frankyn for finding the cause of the |
|
These failures still occur in the Kokoro CI environment. |
|
Hi, I see this is now OOSLO. @bajajneha27 do you need any support on next steps here? I'm on duty this week for the storage DPE team so happy to assist. |
|
Hi, I'm sorry, I haven't been able to look at it. I tried debugging this and I'm running into the issue: |
3 tasks
|
Hi, Also, these tests may fail in your local as they were failing for me due to permission issue |
|
@bajajneha27 I also see the successful CI acceptance test run now for your open PR #14407, thank you for providing the links. I would recommend closing this issue now. |
|
Great, thanks for following up! I will close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
On Ruby 2.5, we get this. This is from the nightly on 2021-04-26.
On Ruby 3.0, we get this. From the same nightly.
The text was updated successfully, but these errors were encountered: