Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CMEK support to Bigtable #10880

Closed
10 tasks done
quartzmo opened this issue Mar 16, 2021 · 0 comments · Fixed by #10888
Closed
10 tasks done

Add CMEK support to Bigtable #10880

quartzmo opened this issue Mar 16, 2021 · 0 comments · Fixed by #10888
Assignees
@quartzmo
Labels
api: bigtable Issues related to the Bigtable API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@quartzmo
Copy link
Member

quartzmo commented Mar 16, 2021 •
edited

This feature is similar to the CMEK support in google-cloud-bigquery, google-cloud-pubsub and google-cloud-storage. It should use the attribute/param name kms_key for consistency with those existing implementations.

Feature checklist:

  • Add kms_key to Instance::ClusterMap#add.
  • Add Cluster#kms_key (EncryptionConfig#kms_key_name).
  • Add EncryptionInfo
    • Add EncryptionInfo#encryption_type
    • Add EncryptionInfo#encryption_status
    • Add EncryptionInfo#kms_key_version
  • Add Backup#encryption_info
  • Add ENCRYPTION_VIEW support to Table and Table::ClusterState:
    • Add Table::ClusterState#encryption_infos
    • Update docs for existing fields in Table::ClusterState.

See also the Java reference implementation.
@quartzmo quartzmo self-assigned this Mar 16, 2021
@quartzmo quartzmo added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. api: bigtable Issues related to the Bigtable API. labels Mar 16, 2021
@quartzmo quartzmo mentioned this issue Mar 17, 2021
Merged
quartzmo added a commit to quartzmo/google-cloud-ruby that referenced this issue Apr 18, 2021
@quartzmo
feat(bigtable): Add CMEK support
d78d2f3 
closes: googleapis#10880
quartzmo added a commit that referenced this issue Apr 20, 2021
@quartzmo
feat(bigtable): Add CMEK support
1ebcfb2 
* Add kms_key to ClusterMap#add
* Add Cluster#kms_key
* Add EncryptionInfo
* Add ClusterState#encryption_infos
* Add ENCRYPTION_VIEW support to Table
* Update docs in Table::ClusterState
* Add Backup#encryption_info

closes: #10880
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@quartzmo quartzmo

Labels
api: bigtable Issues related to the Bigtable API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(bigtable): Add CMEK support quartzmo/google-cloud-ruby
1 participant
@quartzmo