Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add presubmits for checking constraints files using lower-bound-checker from google-cloud-testutils #12040

Open
parthea opened this issue Nov 21, 2023 · 0 comments
Open

Add presubmits for checking constraints files using lower-bound-checker from google-cloud-testutils #12040

parthea opened this issue Nov 21, 2023 · 0 comments
Labels
type: process A process-related concern. May include testing, release, or the like.

Comments

@parthea
Copy link
Contributor

parthea commented Nov 21, 2023

Similar to googleapis/gapic-generator-python#1870, there should be a presubmit to confirm that the minimum supported version of a dependency in setup.py is being tested via the constraints files.

See googleapis/synthtool#1901 for context.

The check_lower_bounds nox session exists in gapic-generator-python but not in synthtool templates here.
@parthea parthea added the type: process A process-related concern. May include testing, release, or the like. label Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@parthea