Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

google-cloud-* libraries should allow google-api-core, google-cloud-core, google-auth >1, <3 #10565

Closed
busunkim96 opened this issue Jul 19, 2021 · 4 comments
Closed

google-cloud-* libraries should allow google-api-core, google-cloud-core, google-auth >1, <3 #10565

busunkim96 opened this issue Jul 19, 2021 · 4 comments
Assignees
@busunkim96
Labels
type: process A process-related concern. May include testing, release, or the like.
Projects
Removing Python 2.7 Support

Comments

@busunkim96
Copy link
Contributor

busunkim96 commented Jul 19, 2021 •
edited

For all google-cloud-* libraries that require python >=3.6, expand google-api-core, google-cloud-core and google-auth pins to >1.x.x, <3.0.0dev.

Leave a comment in the setup.py for these libraries asking library maintainers to not require >=2.x.x versions until #10566 has been closed.

Release google-cloud-* libraries with expanded pins.

dependencies = [
    # NOTE: Maintainers, please do not require google-api-core>=2.x.x
    # Until this issue is resolved:  https://github.com/googleapis/google-cloud-python/issues/10566
    "google-api-core[grpc] >= 1.26.0, <3.0.0dev",
    "proto-plus >= 1.15.0",
    "packaging >= 14.3",
]

This issue can be closed when all google-cloud-* libraries have latest releases with <3.0.0dev pins.
@busunkim96 busunkim96 added the type: process A process-related concern. May include testing, release, or the like. label Jul 19, 2021
@busunkim96 busunkim96 self-assigned this Jul 19, 2021
@busunkim96 busunkim96 added this to To do in Removing Python 2.7 Support via automation Jul 19, 2021
@busunkim96 busunkim96 mentioned this issue Jul 19, 2021
Closed
@busunkim96 busunkim96 changed the title google-cloud-* libraries should allow google-api-core, google-auth >1, <3 google-cloud-* libraries should allow google-api-core, google-cloud-core, google-auth >1, <3 Jul 19, 2021
This was referenced Jul 19, 2021
Merged
Merged
Merged
gcf-merge-on-green bot pushed a commit to googleapis/python-automl that referenced this issue Jul 20, 2021
@busunkim96
fix(deps): pin 'google-{api,cloud}-core', 'google-auth' to allow 2.x …
2cf09fa 
…versions (#209)

Expand pins on library dependencies in preparation for these dependencies taking a new major version. See googleapis/google-cloud-python#10565.
gcf-merge-on-green bot pushed a commit to googleapis/python-speech that referenced this issue Jul 20, 2021
@busunkim96
fix(deps): pin 'google-{api,cloud}-core', 'google-auth' to allow 2.x …
44d3f5b 
…versions (#210)

Expand pins on library dependencies in preparation for these dependencies taking a new major version. See googleapis/google-cloud-python#10565.
@tseaver
Copy link
Contributor

tseaver commented Jul 27, 2021 •
edited

Possibly useful Github searches for eyeball-verification of the pins:

This was referenced Jul 27, 2021
Merged
Merged
gcf-merge-on-green bot pushed a commit to googleapis/python-dns that referenced this issue Jul 28, 2021
@tseaver
chore: add comment linking tracking issue (#70)
5ecf845 
Conform to spec in googleapis/google-cloud-python#10565.
@busunkim96 busunkim96 mentioned this issue Jul 28, 2021
Merged
gcf-merge-on-green bot pushed a commit to googleapis/python-runtimeconfig that referenced this issue Jul 28, 2021
@tseaver
chore: add comment linking tracking issue (#76)
48f6c10 
Conform to spec in googleapis/google-cloud-python#10565.
@busunkim96
Copy link
Contributor Author

Thanks Tres!

I looked through repos (using the list in the README) and it looks like expanded pins have been released almost everywhere. These were the stragglers I found:

@tseaver
Copy link
Contributor

tseaver commented Jul 28, 2021 •
edited

I've been working today to get the Spanner release done -- it has been was blocked by a breaking OpenTelemetry change, now fixed, and is marked automerge.

Looks like you merged the Logging one: I will review have merged the other three.

@tseaver
Copy link
Contributor

tseaver commented Jul 29, 2021 •
edited

Uh, oh, the Spanner 3.7.0 release PR is held up: @larkee marked it as do not release last night.

It merged this evening.

@tseaver tseaver closed this as completed Aug 2, 2021
atulep pushed a commit that referenced this issue Apr 3, 2023
@busunkim96
fix(deps): pin 'google-{api,cloud}-core', 'google-auth' to allow 2.x …
8bf884e 
…versions (#210)

Expand pins on library dependencies in preparation for these dependencies taking a new major version. See #10565.
atulep pushed a commit that referenced this issue Apr 6, 2023
@busunkim96
fix(deps): pin 'google-{api,cloud}-core', 'google-auth' to allow 2.x …
72067a9 
…versions (#210)

Expand pins on library dependencies in preparation for these dependencies taking a new major version. See #10565.
atulep pushed a commit that referenced this issue Apr 6, 2023
@busunkim96
fix(deps): pin 'google-{api,cloud}-core', 'google-auth' to allow 2.x …
ed69c72 
…versions (#210)

Expand pins on library dependencies in preparation for these dependencies taking a new major version. See #10565.
atulep pushed a commit that referenced this issue Apr 18, 2023
@busunkim96
fix(deps): pin 'google-{api,cloud}-core', 'google-auth' to allow 2.x …
f505e26 
…versions (#210)

Expand pins on library dependencies in preparation for these dependencies taking a new major version. See #10565.
parthea pushed a commit that referenced this issue Oct 21, 2023
@busunkim96
fix(deps): pin 'google-{api,cloud}-core', 'google-auth' to allow 2.x …
af792dc 
…versions (#209)

Expand pins on library dependencies in preparation for these dependencies taking a new major version. See #10565.
parthea pushed a commit that referenced this issue Oct 22, 2023
@busunkim96
fix(deps): pin 'google-{api,cloud}-core', 'google-auth' to allow 2.x …
c6ed0a3 
…versions (#210)

Expand pins on library dependencies in preparation for these dependencies taking a new major version. See #10565.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@busunkim96 busunkim96

Labels
type: process A process-related concern. May include testing, release, or the like.
Projects
No open projects
Removing Python 2.7 Support
To do
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tseaver @busunkim96