Some service client calls are throwing exceptions that aren't annotated #6498
Labels
api: retail
Issues related to the Retail API API.
needs more info
This issue needs more information from the customer to proceed.
priority: p2
Moderately-important priority. Fix may not be included in next release.
Take for example
PredictionServiceClient
:google-cloud-php/Retail/src/V2/Gapic/PredictionServiceGapicClient.php
Lines 423 to 425 in d108fd6
PredictionServiceClient::predict()
declares that it can throwGoogle\ApiCore\ApiException
, but there's no mention of theGuzzleHttp\Exception\GuzzleException
s that it will throw e.g. as part of the authentication flow.I brought this up in googleapis/gax-php#474, but it seems on the side of
google/gax
this behavior is intended.(see also that issue for a reproduction case)
Thus the exception signatures on these clients are currently unreliable.
The text was updated successfully, but these errors were encountered: