Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Upgrade Guzzlehttp/psr7 version #4508

Merged

Conversation

saranshdhingra
Copy link
Contributor

This PR aims to resolve version dependency issues related to older versions(<1.7) for guzzlehttp/psr7 package. See issue #4247 for details.

The use of deprecated methods have been removed and the dependencies have been upgraded.

@saranshdhingra saranshdhingra requested review from a team as code owners September 7, 2021 11:18
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 7, 2021
Copy link
Contributor

@dwsupplee dwsupplee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you @saranshdhingra! Just one minor comment.

Core/composer.json Outdated Show resolved Hide resolved
Copy link
Contributor

@bshaffer bshaffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look great! However, I suggest we split this into two PRs, one with just the updates to Core, and one with the changes to the other packages which rely on the update to cloud core (namely, Bigquery, Datastore, Spanner, Storage, and Vision because they rely on guzzlehttp/psr7:1.7).

We then merge the PR for Core, cut a new version (v1.43.0), and update the composer.jsons for the above packages to depend on google/cloud-core:^1.43. The packages which do not use the new classes in 1.7 do not need to be updated.

@bshaffer
Copy link
Contributor

bshaffer commented Sep 9, 2021

These changes look great! However, I suggest we split this into two PRs...

David says we can get away with updating composer.json in the packages I mention above to google/cloud-core:^1.43.0 in this PR (before the release is cut), and release everything at once. So I will leave it up to @dwsupplee / @saranshdhingra to decide whether to split it or not! But you will need to update composer.json for those packages in this PR!

@tjhunkin-inhance
Copy link

Is this fix now available?

@saranshdhingra
Copy link
Contributor Author

Is this fix now available?

Most of the work is done and the dependencies have been updated. We just need to decide on which route to take re: 'splitting' the PRs before releasing.
This should be available soon.

@tjhunkin-inhance
Copy link

will this fix be applied to google/cloud-pubsub as well? Because it has the same issue.

@bshaffer
Copy link
Contributor

@tjhunkin-inhance yes, when this rolls out it will address all of our packages.

@tjhunkin-inhance
Copy link

Awesome, thanks

@saranshdhingra saranshdhingra requested a review from a team as a code owner September 14, 2021 15:21
@dwsupplee dwsupplee changed the title Feat: Upgrade Guzzlehttp/psr7 version feat: Upgrade Guzzlehttp/psr7 version Sep 14, 2021
@dwsupplee dwsupplee merged commit 1062b46 into googleapis:master Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants